APMD-List:
Archives

  From: Craig Markwardt <craigm@pcasun3.gsfc.nasa.gov>
  To  : <apmd-list@worldvisions.ca>
  Date: Fri, 25 Jun 1999 12:08:50 -0400 (EDT)

Re: apmd-3.0beta5-8

Avery Pennarun writes:
 > The apmd warning level is completely separate from the BIOS-generated
 > message.  Perhaps we should disregard the BIOS message entirely.
 > 
 > Craig, is there any reason why we aren't passing "synthetic battery low"
 > messages on to the apmd_proxy?
 > 
 > Does anyone find any use for the BIOS-generated warnings?  Perhaps we should
 > just ignore them.

Heh heh.  In the patch I submitted, apmd_proxy was called for all
kinds of low battery messages.  David Brownell suggested that he was
getting too many notifications and rearranged that bit of code.  I
agree with you, we should treat the two similarly; apmd_proxy should
be called.  Here's a patch snippet.

diff -ur apmd-3.0beta8/apmd.c apmd-3.0beta8cm1/apmd.c
--- apmd-3.0beta8/apmd.c        Tue Jun 15 20:59:19 1999
+++ apmd-3.0beta8cm1/apmd.c     Fri Jun 25 12:02:35 1999
@@ -631,8 +631,8 @@
        }
        break;
     case APM_LOW_BATTERY:
-       apmd_call_proxy(event, apmi);
 synthetic_low_battery:
+       apmd_call_proxy(event, apmi);
        last_battery_status = 1;
        apmd_low_battery(event, apmi);
        break;

Will you be putting out a new version soon?  I know I've submitted a
few patches to you for this and other install bugs.  apmd_proxy should
be updated to better reflect our understanding of what needs to be
done.  David Brownell also suggested we add more documentation for
BIOS workarounds and how to use apmd_proxy (cardctl suspend,
soundoff/on, chvt).

Craig